This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Remote module defaults to false #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enableRemoteModule now defaults to false and is in the verge of being deprecated. https://www.electronjs.org/docs/breaking-changes#default-changed-enableremotemodule-defaults-to-false
Codecov Report
@@ Coverage Diff @@
## master #2712 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 237 237
Lines 13213 13213
Branches 1900 1900
=======================================
Hits 12349 12349
Misses 864 864
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
enableRemoteModulenow defaults to false and is on the verge of being deprecated. We must therefore set it to true in order to maintain the previous behaviour that depends on it.This change also makes electron upgrade to 11.4.7 possible.
Screenshot or Gif
Applicable Issues
atom/atom#22687