This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix for improper highlighting within the ternary operator #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts function and member access tokenizing. add corresponding specs
|
/cc @thomasjo for sanity check :) |
|
@zoo1 Does this handle the pointer dereferencing scenario as well? Would be awesome to have a test added for that at least; e.g. a ? b->c : d |
…iority of access tokenization
|
@thomasjo it now does! A spec has been added to cover the functionality. |
|
@zoo1 Beautiful stuff! Thanks 🙇 |
50Wliu
reviewed
Dec 7, 2016
| 'include': '$self' | ||
| } | ||
| { | ||
| 'include': '#libc' |
There was a problem hiding this comment.
Can these two be moved above $self? I think generally $self should come last in patterns as sort of a default fallback.
This was referenced Jan 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now supports function and member access tokenizing. add corresponding specs
fix for #178
Before:
After:
