New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight broken if text contains ampersand #181

Closed
karlschwaier opened this Issue Dec 13, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@karlschwaier

karlschwaier commented Dec 13, 2017

Description

If a string contains an ampersand, the syntax highlight after that ampersand is broken.

bildschirmfoto 2017-12-13 um 15 03 02

Versions

Atom 1.23.0
language-html 0.48.4

Additional Information

Similar to #141.

@jonathanfleckenstein

This comment has been minimized.

Show comment
Hide comment
@jonathanfleckenstein

jonathanfleckenstein Dec 14, 2017

<iframe height="500px" width="500px"
  src="/v/?num=&height=&width=&autostart=true&repeat=false&force_dimensions=true&controlbar=false&disable_pause=true&disable_opening_frame=true&wmode=transparent&presentation_mode=product_preview&allow_full_screen=false"
  frameborder="0" allowFullScreen="false" webkitallowfullscreen="false" mozallowfullscreen="false"></iframe>

Also happens with this string, but only after the 4th ampersand.
Atom 1.22.1
language-html 0.48.2

jonathanfleckenstein commented Dec 14, 2017

<iframe height="500px" width="500px"
  src="/v/?num=&height=&width=&autostart=true&repeat=false&force_dimensions=true&controlbar=false&disable_pause=true&disable_opening_frame=true&wmode=transparent&presentation_mode=product_preview&allow_full_screen=false"
  frameborder="0" allowFullScreen="false" webkitallowfullscreen="false" mozallowfullscreen="false"></iframe>

Also happens with this string, but only after the 4th ampersand.
Atom 1.22.1
language-html 0.48.2

@jwardbond

This comment has been minimized.

Show comment
Hide comment
@jwardbond

jwardbond Dec 14, 2017

It happens when an ampersand is immediately followed by any alphabetical character.

image

vs.

image

Atom 1.23.1
language-html 0.48.4

jwardbond commented Dec 14, 2017

It happens when an ampersand is immediately followed by any alphabetical character.

image

vs.

image

Atom 1.23.1
language-html 0.48.4

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Dec 20, 2017

Member

@jonathanfleckenstein your issue should be fixed in Atom 1.23.0. I'm looking into the other issues now.

Member

50Wliu commented Dec 20, 2017

@jonathanfleckenstein your issue should be fixed in Atom 1.23.0. I'm looking into the other issues now.

@jonathanfleckenstein

This comment has been minimized.

Show comment
Hide comment
@jonathanfleckenstein

jonathanfleckenstein Dec 26, 2017

@50Wliu Thank you, hope you're having a great Holiday!

jonathanfleckenstein commented Dec 26, 2017

@50Wliu Thank you, hope you're having a great Holiday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment