This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
There is more than one syntax for inline php as shown in the PHP page
The auto-indent currently works for this syntax of inline php:
but when trying this other syntax the indentation breaks:
So I just added
<?php }
to the decreaseIndentPattern to make it properly align.Alternate Designs
I chose this approach because the indentation rules for the alternate syntax were already managed in this variable and it was simply a matter of placing it in the regex.
Benefits
Another syntax of inline php will indent correctly.
Possible Drawbacks
All lines starting with
<?php }
will decrease indent.Applicable Issues
I couldn't find any Issue regarding this.