Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Incorrect highlighting of raw bytes with non-decimal chars in strings #200

Closed
ValarDragon opened this issue May 19, 2017 · 1 comment
Closed
Labels

Comments

@ValarDragon
Copy link

Prerequisites

Description

In strings, normally '\xXX' makes the char at that position chr(int(XX,16)), it converts the hex value XX into that raw byte. However if one of the chars in X is non-decimal (so a-f) it doesn't get recognized.

Steps to Reproduce

Create the string "\x44\xff\x32RandomString\xa4\x4a\x44" in atom, and observe that the bytes with non decimal chars don't get highlighted.

Expected behavior:

All escaped hex bytes inside of strings to be highlighted.

Actual behavior: [What actually happens]

image

Reproduces how often: 100% of the time for me

Versions

I am on Linux Mint 17.3

atom 1.6.2
apm 1.6.0
npm 2.13.3
node 0.10.40
python 2.7.6
git 1.9.1

@50Wliu
Copy link
Contributor

50Wliu commented Jan 21, 2018

Fixed by #215.

@50Wliu 50Wliu closed this as completed Jan 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants