-
Notifications
You must be signed in to change notification settings - Fork 144
Incorrectly highlighted regex #47
Comments
👍 I am having the same issue and just posted it to atom/atom: issues |
Just going to include the snippet that was causing issues in atom/atom#3490 here: value1 = value2 / (1.0 - (percentage / 100.0)) |
Are you sure that this commit fixes this issue? I tried making the changes on my local installation and it didn't seem to fix the issue. |
@deiga The commit should fix the issue @thedaniel was seeing, can you include a code snippet of what you are still seeing failing? |
The enormous regular expression found in the following URL causes all subsequent code to be colored as part of the regex. https://github.com/jzaefferer/jquery-validation/blob/master/src/core.js#L1119 I know this is a line of Javascript, but the regex works just fine in Ruby. Here's a screenshot of what this looks like in Atom. |
@angelman I think you are seeing atom/atom#1667 |
@kevinsawicki You are right. Never mind. :) |
@kevinsawicki It's still the same as in #47 (comment) |
@deiga that could be a different issue, mind including the code snippet? It makes it much quicker to reproduce than retyping it from a screenshot. |
|
Only consume / if they are escaped before the ending / Refs #47
@deiga Great, thanks for the snippet, just pushed a fixed for it |
this code has broken highlighting - note the red closing slash on the regex and wash of redness below it
The text was updated successfully, but these errors were encountered: