Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

🎁 Add SassDoc grammar patterns #251

Merged
merged 10 commits into from
May 2, 2018

Conversation

stormwarning
Copy link
Contributor

@stormwarning stormwarning commented Mar 30, 2018

Description of the Change

Adds grammar patterns for highlighting SassDoc comments, similar to how JSDoc blocks are handled in language-javascript.

Benefits

Having docblocks highlighted makes them easier to read, and can encourage their use.

@stormwarning
Copy link
Contributor Author

stormwarning commented Apr 3, 2018

I think the patterns for this should be pretty good now. I'm not super-familiar with using Jasmine for tests though — is there an easy way to run the tests locally?

EDIT: Looks like atom --test spec should work; if there's a different workflow for local testing let me know!

@stormwarning
Copy link
Contributor Author

Tests are added! This should be good to go, barring any review feedback or concerns. 🙌

@lee-dohm
Copy link
Contributor

lee-dohm commented Apr 6, 2018

@stormwarning Would it be possible for you to give us a "representative" before and after screenshot just so that I can get an idea of what changes this is going to make? Our normal language person is out right now and I'm filling in a bit.

@stormwarning
Copy link
Contributor Author

@lee-dohm Absolutely, thanks!

Before:
language-sass-before

After:
language-sass-after

Type annotations don't require curly braces around the type name(s).
@stormwarning
Copy link
Contributor Author

Realised @type tags don't need {} around the type name so I fixed that up. Is there anything else I can do to help move this forward?

@lee-dohm lee-dohm merged commit f30638d into atom:master May 2, 2018
@lee-dohm
Copy link
Contributor

lee-dohm commented May 2, 2018

Looks good to me! Thanks for the help 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants