New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Add test for bug fixed in 2ff4ee3f83 #47

Merged
merged 3 commits into from Jun 16, 2017

Conversation

Projects
None yet
1 participant
@jasonrudolph
Member

jasonrudolph commented Jun 6, 2017

Description of the Change

This pull request adds a test for the bug fixed in 2ff4ee3.

Normally, I prefer to add the test first and then fix the bug second. We were in a bit of a time crunch to get #46 shipped, so I committed the bug fix in that PR, and I'm following up with this PR to add the corresponding test.

It's probably easier to review this PR's individual commits than it is to review the consolidated diff. For example, f5ea7d0 refactors the existing tests to make room for adding a new test related to the bug. Then, ed3da09 adds the new test related to the bug.

Alternate Designs

N/A

Benefits

We're less likely to accidentally re-introduce the bug fixed in 2ff4ee3.

Possible Drawbacks

N/A

Applicable Issues

#46

jasonrudolph added some commits Jun 6, 2017

Improve accuracy of test description
This test does more than just click out of the active text editor; it
_destroys_ the active text editor. If you only click out of the active
text editor, the status bar will still show the text editor's line
endings.
Add test for bug fixed in 2ff4ee3
Add test to prevent accidentally re-introducing the bug that was fixed
in 2ff4ee3.

@jasonrudolph jasonrudolph merged commit 6552cab into master Jun 16, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the jr-add-test-for-non-editor-element-having-focus branch Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment