This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
✅ Add test for bug fixed in 2ff4ee3f83 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test does more than just click out of the active text editor; it _destroys_ the active text editor. If you only click out of the active text editor, the status bar will still show the text editor's line endings.
Add test to prevent accidentally re-introducing the bug that was fixed in 2ff4ee3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request adds a test for the bug fixed in 2ff4ee3.
Normally, I prefer to add the test first and then fix the bug second. We were in a bit of a time crunch to get #46 shipped, so I committed the bug fix in that PR, and I'm following up with this PR to add the corresponding test.
It's probably easier to review this PR's individual commits than it is to review the consolidated diff. For example, f5ea7d0 refactors the existing tests to make room for adding a new test related to the bug. Then, ed3da09 adds the new test related to the bug.
Alternate Designs
N/A
Benefits
We're less likely to accidentally re-introduce the bug fixed in 2ff4ee3.
Possible Drawbacks
N/A
Applicable Issues
#46