Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
✅ Add test for bug fixed in 2ff4ee3f83 #47
Description of the Change
This pull request adds a test for the bug fixed in 2ff4ee3.
Normally, I prefer to add the test first and then fix the bug second. We were in a bit of a time crunch to get #46 shipped, so I committed the bug fix in that PR, and I'm following up with this PR to add the corresponding test.
It's probably easier to review this PR's individual commits than it is to review the consolidated diff. For example, f5ea7d0 refactors the existing tests to make room for adding a new test related to the bug. Then, ed3da09 adds the new test related to the bug.
We're less likely to accidentally re-introduce the bug fixed in 2ff4ee3.