New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore scrollTop of viewElement for smoother livereload #477

Merged
merged 2 commits into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@dsumer
Contributor

dsumer commented Mar 24, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

When the PreviewView is reloaded after a change, the scrollTop is being reset to 0, which is quite annoying when writing a Markdown file while the view is scrolled to the current position.

With this Change the scrollTop will be restored after rerendering the PreviewView.

Alternate Designs

Benefits

Smoother rerendering of the PreviewView with livereload.
Resolves #370

Possible Drawbacks

Applicable Issues

#370

@50Wliu 50Wliu added the needs-review label Mar 25, 2017

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Sep 28, 2017

Contributor

@dsumer Nice work, really sorry for how long it took for us to look at it.

Contributor

maxbrunsfeld commented Sep 28, 2017

@dsumer Nice work, really sorry for how long it took for us to look at it.

@maxbrunsfeld maxbrunsfeld merged commit 2834853 into atom:master Sep 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Sep 28, 2017

Contributor

This will go out in Atom 1.22.

Contributor

maxbrunsfeld commented Sep 28, 2017

This will go out in Atom 1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment