This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
restore scrollTop of viewElement for smoother livereload #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsumer Nice work, really sorry for how long it took for us to look at it. |
|
This will go out in Atom 1.22. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
When the PreviewView is reloaded after a change, the scrollTop is being reset to 0, which is quite annoying when writing a Markdown file while the view is scrolled to the current position.
With this Change the scrollTop will be restored after rerendering the PreviewView.
Alternate Designs
Benefits
Smoother rerendering of the PreviewView with livereload.
Resolves #370
Possible Drawbacks
Applicable Issues
#370