Add specs and use node to send data

.gitignore

@@ -0,0 +1 @@
+node_modules

lib/collector.coffee

@@ -5,24 +5,26 @@ module.exports =
     constructor: ->
       @sessionId = new Date().getTime()
 
-    # Public: Logs out the data that will be sent.
-    log: ->
-      console.debug JSON.stringify(@getData())
-
     # Private
     getPath: ->
       global.project.getPath()
 
-    # Public: Returns the name of the currently logged in user.
+    # Private
     getUser: ->
       process.env.USER
 
+    # Private
     getSessionId: ->
       @sessionId
 
     # Public: Returns an object containing all data collected.
     getData: (additionalData) ->
       data =
-        windowPath: @getPath()
-        sessionId: @getSessionId()
+        window_path: @getPath()
+        session_id: @getSessionId()
+        actor_login: @getUser()
+        user_agent: 'Atom v25.0.0'
+        screen_resolution: '2560x1440'
+        pixel_ratio: 1
+        browser_resolution: '1360x923'
       _.extend(data, additionalData)

lib/metrics.coffee

@@ -2,11 +2,11 @@ Collector = require './collector'
 Reporter = require './reporter'
 
 module.exports =
+  collector: new Collector()
+  reporter: new Reporter()
+
   activate: (state) ->
-    @collector = new Collector()
-    # FIXME: you have to use 'recordPageView'
-    new Reporter('recordPageView', @collector.getUser(), @collector.getData())
+    @reporter.send(@collector.getData(action: 'activate'))
 
   deactivate: ->
-    # FIXME: you have to use 'recordPageView'
-    new Reporter('recordPageView', @collector.getUser(), @collector.getData())
+    @reporter.send(@collector.getData(action: 'deactivate'))

lib/reporter.coffee

@@ -1,13 +1,15 @@
-require './octolytics'
+request = require 'request'
 
 module.exports =
   class Reporter
-    constructor: (event, user, data) ->
-      window._octo.setApp('atom')
-      window._octo.setHost('collector-staging.githubapp.com')
+    constructor: ->
+      @request = request
 
-      window._octo.setActor
-        login: user
+    send: (data) ->
+      params = timestamp: new Date().getTime()
+      for key, value of data
+        params["dimensions[#{key}]"] = value
 
-      window._octo.setDimensions(data)
-      window._octo.push([event])
+      @request
+        url: "https://collector-staging.githubapp.com/atom/page_view"
+        qs: params

package.json

@@ -13,6 +13,9 @@
   "engines": {
     "atom": ">25.0"
   },
+  "dependencies": {
+    "request": "2.27.0"
+  },
   "publishConfig": {
     "registry": "https://atom.iriscouch.com/registry/_design/app/_rewrite"
   }

spec/collector-spec.coffee

@@ -0,0 +1,20 @@
+_ = require 'underscore'
+Collector = require '../lib/collector'
+
+fdescribe "Collector", ->
+  subject = null
+  beforeEach ->
+    subject = new Collector
+
+  describe "getData", ->
+    beforeEach ->
+
+    it "creates a request with the proper options", ->
+      keys = _.keys(subject.getData())
+      expect(keys).toContain 'user_agent'
+      expect(keys).toContain 'screen_resolution'
+      expect(keys).toContain 'pixel_ratio'
+      expect(keys).toContain 'browser_resolution'
+      expect(keys).toContain 'window_path'
+      expect(keys).toContain 'session_id'
+      expect(keys).toContain 'actor_login'

spec/metrics-spec.coffee

@@ -1,5 +1,20 @@
-Metrics = require '../lib/metrics'
+metrics = require '../lib/metrics'
 
-describe "Metrics", ->
-  it "has one valid test", ->
-    expect("life").toBe "easy"
+fdescribe "Metrics", ->
+  describe "upon loading", ->
+    beforeEach ->
+      spyOn(metrics.reporter, 'send')
+      metrics.activate()
+
+    it "reports a page view", ->
+      expect(metrics.reporter.send).toHaveBeenCalled()
+      expect(metrics.reporter.send.calls[0].args[0]).toEqual metrics.collector.getData(action: 'activate')
+
+  describe "upon unloading", ->
+    beforeEach ->
+      spyOn(metrics.reporter, 'send')
+      metrics.deactivate()
+
+    it "reports a page view", ->
+      expect(metrics.reporter.send).toHaveBeenCalled()
+      expect(metrics.reporter.send.calls[0].args[0]).toEqual metrics.collector.getData(action: 'deactivate')

spec/reporter-spec.coffee

@@ -0,0 +1,17 @@
+Reporter = require '../lib/reporter'
+
+fdescribe "Reporter", ->
+  subject = null
+  beforeEach ->
+    subject = new Reporter
+
+  describe "send", ->
+    beforeEach ->
+      spyOn(subject, 'request')
+      subject.send(key: 'value')
+
+    it "creates a request with the proper options", ->
+      expect(subject.request).toHaveBeenCalled()
+      expect(subject.request.calls[0].args[0].url).toBe 'https://collector-staging.githubapp.com/atom/page_view'
+      expect(subject.request.calls[0].args[0].qs['dimensions[key]']).toBe 'value'
+      expect(subject.request.calls[0].args[0].qs['dimensions[timestamp]']).not.toBeNull()