This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Restore missing assertion in issue title truncation test #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshaber
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
#76 added the logic to truncate issue titles to 100 characters, and it added a test to verify that logic. That test included an assertion to verify the truncated issue title.
#114 updated a handful of existing tests and happened to remove the assertion that verified truncation of the issue title.
Because that assertion was removed, it's currently possible to delete the code that truncates the issue title, and the issue title truncation test will still pass. 馃槵
This pull request updates the test to once again verify issue title truncation.
@joshaber: I suspect this particular removal in #114 was unintentional. Can you confirm that theory? (I realize that the PR shipped more than a year ago, so if you don't recall, I completely understand. 馃槆)
Alternate Designs
None
Benefits
Improve test coverage and reduce opportunity for regressions related to issue title generation
Possible Drawbacks
None that I'm aware of
Applicable Issues
/cc #76 #114