Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Restore missing assertion in issue title truncation test #158

Merged
merged 2 commits into from May 25, 2017
Merged

Restore missing assertion in issue title truncation test #158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e674e75
Restore assertion verifying issue title truncation
jasonrudolph May 24, 2017
84f9601
:art: Rename variable to increase clarity
jasonrudolph May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/notifications-spec.coffee
View file
Open in desktop
Expand Up @@ -680,7 +680,7 @@ describe "Notifications", ->

describe "when the message is longer than 100 characters", ->
message = "Uncaught Error: Cannot find module 'dialog'Error: Cannot find module 'dialog' at Function.Module._resolveFilename (module.js:351:15) at Function.Module._load (module.js:293:25) at Module.require (module.js:380:17) at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/atom/browser/lib/rpc-server.js:128:79) at EventEmitter.emit (events.js:119:17) at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/atom/browser/api/lib/web-contents.js:99:23) at EventEmitter.emit (events.js:119:17)"
truncatedMessage = "Uncaught Error: Cannot find module 'dialog'Error: Cannot find module 'dialog' at Function.Module...."
expectedIssueTitle = "Uncaught Error: Cannot find module 'dialog'Error: Cannot find module 'dialog' at Function.Module...."

beforeEach ->
generateFakeFetchResponses()
Expand All @@ -699,8 +699,8 @@ describe "Notifications", ->

runs ->
button = fatalError.querySelector('.btn')
encodedMessage = encodeURIComponent(truncatedMessage)
expect(button.textContent).toContain 'Create issue'
expect(fatalError.issue.getIssueTitle()).toBe(expectedIssueTitle)

describe "when the package is out of date", ->
beforeEach ->
Expand Down