This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Clear log #180
Merged
Merged
Clear log #180
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2428308
add clear log button
UziTech c0df23e
clear non-dismissable notifications
UziTech fd69ffe
remove -plus
UziTech 8e1dccf
use trashcan icon
UziTech 605cc82
use onDidClearNotifications
UziTech 373a2b6
clearLogItems
UziTech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ | |
background-color: @base-background-color; | ||
border-bottom: 1px solid @base-border-color; | ||
|
||
.notification-type { | ||
button { | ||
border: none; | ||
width: @icon-size; | ||
height: @icon-size; | ||
|
@@ -24,6 +24,10 @@ | |
opacity: .5; | ||
background: @base-background-color; | ||
} | ||
|
||
.notifications-clear-log { | ||
float: right; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @UziTech: When you have a moment, can you share screenshots of this new icon is rendered in each of the UI themes that ship with Atom? I suspect it renders just fine, but we want to make sure. 😅 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
.notifications-log-items { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Under what circumstances will there be an already-dismissed notification in the list that we need to dismiss again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-dimissable notifications (ones that dismiss automatically) have
.dismissed
= true when they are first shown. If someone clears the log we want those notifications to be dismissed right away not wait for the timer to dismiss them automatically.