Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Packages using short GitHub URIs have broken repo links and some missing metadata #543

Closed
mnquintana opened this issue Jun 12, 2015 · 4 comments

Comments

@mnquintana
Copy link
Contributor

screenshot 2015-06-12 07 20 42

This is https://atom.io/packages/jshint - it uses a repo path of the form username/repo in package.json. The repo link in the package card is missing the first letter, and tries to open an invalid URL. The package card also failed to download the username and avatar from GitHub.

Atom 0.210.0-7a6a48d

/cc @jlord

@jerone
Copy link
Contributor

jerone commented Jun 27, 2015

Related: #505

@evjan
Copy link
Contributor

evjan commented Oct 17, 2015

Atom 1.0.19 seems to no longer show GitHub links, but the avatar and username still aren't being loaded properly.

screen shot 2015-10-17 at 10 09 02 pm

@jerone
Copy link
Contributor

jerone commented Oct 17, 2015

Atom 1.0.19 seems to no longer show GitHub links

You need to go into the package details / settings view to see the repo link.

the avatar and username still aren't being loaded properly

That is another issue #327 which is hopefully been solved with #661 which hasn't been released with a new Atom version (yet).

@evjan
Copy link
Contributor

evjan commented Oct 17, 2015

@jerone Thanks! I don't think #661 would fix this, the problem AFAICT is in utils.coffee. It doesn't see a short GitHub URI like "sindresorhus/atom-jshint" as something it can extract the owner name from and therefore it fails. I'm working on a fix right now, will submit PR as soon as I have it done.

evjan added a commit to evjan/settings-view that referenced this issue Oct 17, 2015
If an author of a package specified 'authorName/packageName' instead
of 'https://github.com/authorName/packageName', the link to the author
and the avatar image would be broken when looking at the package card.

Now the short GitHub URI is converted to a long one and it works.

Fixes atom#543
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants