This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 275
Packages using short GitHub URIs have broken repo links and some missing metadata #543
Labels
Comments
Related: #505 |
You need to go into the package details / settings view to see the repo link.
That is another issue #327 which is hopefully been solved with #661 which hasn't been released with a new Atom version (yet). |
@jerone Thanks! I don't think #661 would fix this, the problem AFAICT is in utils.coffee. It doesn't see a short GitHub URI like "sindresorhus/atom-jshint" as something it can extract the owner name from and therefore it fails. I'm working on a fix right now, will submit PR as soon as I have it done. |
evjan
added a commit
to evjan/settings-view
that referenced
this issue
Oct 17, 2015
If an author of a package specified 'authorName/packageName' instead of 'https://github.com/authorName/packageName', the link to the author and the avatar image would be broken when looking at the package card. Now the short GitHub URI is converted to a long one and it works. Fixes atom#543
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is https://atom.io/packages/jshint - it uses a repo path of the form
username/repo
inpackage.json
. The repo link in the package card is missing the first letter, and tries to open an invalid URL. The package card also failed to download the username and avatar from GitHub.Atom 0.210.0-7a6a48d
/cc @jlord
The text was updated successfully, but these errors were encountered: