This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Avoid throwing null pointer exceptions when package update fails #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, send assertion failures back to bugsnag when this happens.
| errorStack: error.stack, | ||
| errorStderr: error.stderr | ||
| } | ||
| console.error("Updating #{@type} #{pack.name} to #{version} failed:\n", error, error.stderr ? '') |
There was a problem hiding this comment.
Should this be a notification instead?
There was a problem hiding this comment.
That's a good point, although we'd like to keep this pull-request scoped to fixing the bug without changing how we present the error.
There was a problem hiding this comment.
Ah, I didn't notice that it was already a console.error beforehand.
nathansobo
pushed a commit
that referenced
this pull request
Aug 10, 2016
Avoid throwing null pointer exceptions when package update fails
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, send assertion failures back to bugsnag when this happens.
Fixes #766