This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Hide unnamed grammars in package-detail view #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many packages include "anonymous" grammars to store embeddable patterns; these shouldn't be visible to the end user. References: atom/grammar-selector#34
|
Sigh... Travis brings nothing but pain, I swear.
Seems to be a race condition, but it's not related to this PR. Running the specs enough times on master eventually leads to the same result. |
|
@thomasjo Any idea why the specs are passing 4/5 times locally, but failing every time in CI? Can you reproduce this locally? Even on master? I attempted to amend the specs by loading both No idea what to do right now. =) |
|
The test that's failing is flakey in master already and isn't caused by your code. Thanks for your contribution! |
|
No problem! :-) I thought it was, because it failed on master too. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't uncommon for language packages to include a few "helper" grammars for internal use. Most of the time, this is to provide embeddable highlighting for one or more "real" grammars. These shouldn't be visible to the end user... and certainly not with a title of
undefined Grammar:Complements: atom/grammar-selector#34