Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Ensure excluded scopes are respected #252

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Conversation

maxbrunsfeld
Copy link
Contributor

Fixes #238

There were two bugs in the the logic for excluding scopes:

  1. Due to the wrong Config method being called, the excluded scopes were only used when the excludedScopes setting changed, not during initialization of the packages.
  2. The misspellings needed to be updated after the buffer finished tokenizing, because when initially spell-checking a file, the scopes might not be present.

@maxbrunsfeld maxbrunsfeld merged commit 2a85823 into master Apr 25, 2018
@maxbrunsfeld maxbrunsfeld deleted the mb-fix-excluded-scopes branch April 25, 2018 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant