This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Rename username to login in IdentityProvider
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
real-time-client serializes the `login` property when broadcasting peer identities in the host. Hence, portal guests were receiving an incorrect version of the identity which contained an empty `login` string. Tests were not catching this because we mock all the interactions with the identity provider, and the fake provider uses the correct `login` property.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
real-time-client serializes the
loginproperty when broadcasting peer identities in the host. Hence, portal guests were receiving an incorrect version of the identity which contained an emptyloginstring.Tests were not catching this because we mock all the interactions with the identity provider, and the fake provider uses the correct
loginproperty./cc: @nathansobo @jasonrudolph