Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Ensure package handles expired ICE server credentials #48

Open
jasonrudolph opened this issue Sep 15, 2017 · 1 comment
Open

Ensure package handles expired ICE server credentials #48

jasonrudolph opened this issue Sep 15, 2017 · 1 comment

Comments

@jasonrudolph
Copy link
Contributor

In the real-time package, we create and memoize a single RealTimeClient instance. The RealTimeClient instance creates a PeerPool instance. The PeerPool instance fetches the current ICE server URLs/credentials, and stores them for the life of the PeerPool instance. However, the ICE server URLs/credentials expire within 24 hours [1].

With this context in mind, I wonder what happens if you open an Atom instance, leave it open for more than 24 hours, and then try to share or join a portal. I suspect that any attempt to access the ICE server URLs would fail.

@nathansobo: Does that ☝️ sound right? If so, I'm guessing that we'll need some way for the RealTimeClient to ensure that it always has fresh (i.e., not-yet-expired) ICE server URLs/credentials.


[1] Twilio API docs: https://www.twilio.com/docs/api/rest/token

@nathansobo
Copy link
Contributor

Great thinking! We probably need to pass the TTL on to the client so it can be conservative about expiring its credentials as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants