Joining the same portal again while being connected throws error

[ungb]

[Enter steps to reproduce:]

1. Host shares a portal
2. You connect to that portal
3. Join the same portal again.

Expected: given warning that you're already connected to that portal

Actual: see below on error thrown

Atom: 1.22.0-dev-1f25cda7c x64
Electron: 1.6.9
OS: Mac OS X 10.12.6
Thrown From: real-time package 0.1.0

Stack Trace

Uncaught TypeError: this.resolveConnectionPromise is not a function

At /Users/bungdonuts/github/packages/real-time/node_modules/@atom/real-time-client/lib/star-overlay-network.js:203

TypeError: this.resolveConnectionPromise is not a function
    at StarOverlayNetwork.receiveConnectionAck (/packages/real-time/node_modules/@atom/real-time-client/lib/star-overlay-network.js:203:10)
    at StarOverlayNetwork.receive (/packages/real-time/node_modules/@atom/real-time-client/lib/star-overlay-network.js:167:12)
    at Function.module.exports.Emitter.simpleDispatch (/packages/real-time/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/packages/real-time/node_modules/event-kit/lib/emitter.js:141:28)
    at PeerPool.didReceiveMessage (/packages/real-time/node_modules/@atom/real-time-client/lib/peer-pool.js:90:18)
    at PeerConnection.finishReceiving (/packages/real-time/node_modules/@atom/real-time-client/lib/peer-connection.js:205:10)
    at PeerConnection.receive (/packages/real-time/node_modules/@atom/real-time-client/lib/peer-connection.js:196:14)
    at RTCDataChannel.channel.onmessage (/packages/real-time/node_modules/@atom/real-time-client/lib/peer-connection.js:109:47)

Commands

     -0:26 real-time:join-portal (input.hidden-input)
     -0:25.5.0 core:confirm (input.hidden-input)
     -0:21.3.0 command-palette:toggle (input.hidden-input)
     -0:19.7.0 core:move-down (input.hidden-input)
     -0:19.4.0 core:confirm (input.hidden-input)
     -0:19.4.0 real-time:leave-portal (input.hidden-input)
     -0:18.8.0 command-palette:toggle (input.hidden-input)
     -0:16.1.0 core:move-down (input.hidden-input)
     -0:13.9.0 core:confirm (input.hidden-input)
     -0:13.9.0 real-time:join-portal (input.hidden-input)
     -0:13.2.0 core:confirm (input.hidden-input)
     -0:12.1.0 command-palette:toggle (input.hidden-input)
     -0:10.7.0 core:move-down (input.hidden-input)
     -0:10.4.0 core:confirm (input.hidden-input)
     -0:10.4.0 real-time:join-portal (input.hidden-input)
     -0:09.3.0 core:confirm (input.hidden-input)

Non-Core Packages

real-time 0.1.0 

[jasonrudolph]

@ungb: Can you please share the steps needed to reproduce this issue?

[ungb]

@jasonrudolph I updated the steps. Sorry I was in pairing session with @Ben3eeE and @rsese running other test cases. About to file the other issues we found.

I'll add a gif in a few min

[jasonrudolph]

@ungb: Nice find. Thanks for reporting this issue. 🙇

[jasonrudolph]

If the user attempts to join a portal that they're already participating in, perhaps we should focus the editor for that portal. That feels like the simplest thing that could possibly work. I'll plan to take a look at this 🔜.