This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix preceding boundary calculation for changes inside of folds #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a change is inside a fold and that fold appears at the beginning of a soft-wrapped line segment, we need to continue iterating upward in our search for a line boundary. Previously we would stop because the screen column was 0, but that is invalid if the beginning of the buffer row isn't on screen due to being folded. Signed-off-by: Antonio Scandurra <as-cii@github.com>
nathansobo
pushed a commit
that referenced
this pull request
Feb 17, 2017
Fix preceding boundary calculation for changes inside of folds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a change is inside a fold and that fold appears at the beginning of a soft-wrapped line segment, we need to continue iterating upward in our search for a line boundary. Previously we would stop because the screen column was 0, but that is invalid if the beginning of the buffer row isn't on screen due to being folded.
We also think the new logic in
findBoundaryPrecedingBufferRowexpresses the intent of the method more clearly now.馃崘d with @as-cii
/cc @maxbrunsfeld