This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Supporting all of minimatch's features should be given more thought and extension ignoring is the common case that really needs initial support.
- Loading branch information
1 parent
8029a05
commit a80d265
Showing
2 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a80d265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
a80d265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this trip up a few people now (atom/atom#1966). It's true that extension globs are the common case, but I found it a little surprising that you can't do full globbing, too. I was about to add a PR to enable it when I saw that you'd explicitly taken it out.
What was the concern here? Performance, or just avoiding dependency bloat?