Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add custom style for files/dirs matching core:ignoredNames #1048
Git-ignored files/dirs have the custom class
I.e. if the tree-view config setting
Considered only changing the view but the logic would have complicated their code.
Visual cue of what files/precedence that are ignored.
Potential bugs/regressions not covered by current test suite, I guess.
I apologize for the long wait on this.
In taking a deeper look here, we would be interested in accepting this change if it had separate style for CVS ignored files and files that are ignored via
What do you think?
No worries, I know you have a lot of PRs to review. :)
Yeah, I think your suggestions is sensible. Do you have any recommendation for the styling though?
Apologies for my incorrect terminology. I was suggesting that you create an additional class name like
Ah ok, that makes sense. Merged with master to fix the conflicts and changed the status to be different if ignored by named as you suggestion. Looks OK?
BTW, looks like the test suite is malfunctioning on AppVeyor (same error on the latest PRs as well).