This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
🐛 Disallow moving root directories #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving a root directory can cause the tree view to become invalid as the project remains but does not correctly map to a directory on the file system. It also provides a bad UX as it's very easy to accidentally move a project directory. Fixes #590
|
Thanks! |
| @@ -75,6 +75,9 @@ describe "TreeView", -> | |||
| it "selects the root folder", -> | |||
| expect(treeView.selectedEntry()).toEqual(treeView.roots[0]) | |||
|
|
|||
| it "makes the root folder non-draggable", -> | |||
| expect(treeView.roots[0].hasAttribute('draggable')).toBe(true) | |||
There was a problem hiding this comment.
I'm not too familiar with these tests, but shouldn't draggable be false here?
|
@50Wliu good point, the test wasn't correct - I changed it to only set the |
kevinsawicki
added a commit
that referenced
this pull request
Nov 10, 2015
🐛 Disallow moving root directories
|
Thanks for this 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a root directory can cause the tree view to become invalid as the
project remains but does not correctly map to a directory on the file system.
It also provides a bad UX as it's very easy to accidentally move a project
directory.
Fixes #590