-
Notifications
You must be signed in to change notification settings - Fork 364
Conversation
I'll miss naturalsort a lot, but I guess performance is more important here. |
@50Wliu ill make a pr soon with a more performant sort, and a spec of what it should achieve. it will be a subset of what the other one did. |
@izuzak good idea, opening one should be good enough. |
just a update on this i am changing the test, to dynamically check if the element is visible and in the correct place |
I'm seeing a couple local test failures on this still. Seems like you may be on that already. Code looks good otherwise as it's a pretty simple removal. |
Tests had to be changed, because the sort order is different
should be good to merge now, ill work on a faster natural sort soon |
Awesome. Please ping me on that one as this was a nice feature, just not worth its present cost. Thanks for your help on this! |
I was about to post an issue requesting natural sort when I realized there already has been a lot of on this. I would like to have this feature, even if it adds 17ms or so. Could you add a config option ? or something ? |
we already merged a very fast implementation of this. im not sure if it has On Tue, Dec 8, 2015 at 6:56 PM Antonin Décimo notifications@github.com
|
fixes:
-#612
-#491
-#449 (tested with 9000folders, it was performant. should still make this async to increase cap)