Skip to content
This repository has been archived by the owner on Apr 6, 2018. It is now read-only.

fix put-operation #205

Merged
merged 1 commit into from
Apr 14, 2014
Merged

fix put-operation #205

merged 1 commit into from
Apr 14, 2014

Conversation

skahack
Copy link
Contributor

@skahack skahack commented Apr 12, 2014

Fix #195 issue.

@bhuga
Copy link
Contributor

bhuga commented Apr 13, 2014

Is this still needed after #198 landed? Sorry it took me a few days to get to it.

@skahack
Copy link
Contributor Author

skahack commented Apr 13, 2014

Yes.
Please try below.

^ is cursor position

^12
34
56

keydown: jjyyp

result:

12
34
56
^5

^12
34
56

keydown: yyjp

result:

12
34
^
1256

@skahack
Copy link
Contributor Author

skahack commented Apr 13, 2014

Ah,, Sorry, I did not notice in the merged #198

Please try below.

^12
34
56

keydown: jyyjp

result:

12
34
56
^34


^12
34
56

keydown: jyyp

result:

12
34
^
34
56

^12
34
56

keydown: jjyyP

12
34
^5656

@bhuga
Copy link
Contributor

bhuga commented Apr 13, 2014

Can merge master/rebase please?

@skahack
Copy link
Contributor Author

skahack commented Apr 13, 2014

ok, I rebased.

@bhuga
Copy link
Contributor

bhuga commented Apr 13, 2014

Okay, I see the remaining issues. Taking this for a spin now.

expect(editor.getCursorScreenPosition()).toEqual [1, 1]

describe "at the middle line", ->
beforeEach ->
vimState.setRegister('"', text: " 456\n", type: 'linewise')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want an integration test of the issues you're solving. Something that sets up an editor, yanks a line, moves, and pastes it. This test will continue to work if we broke the behavior of yank to not include a newline or something silly like that.

@bhuga
Copy link
Contributor

bhuga commented Apr 13, 2014

I need to run out now, but after playing with this it looks like all the problems are fixed. If you can clean up the one or two nitpicks I had I'll get this merged tonight. Would be awesome to finally put this to bed.

@skahack
Copy link
Contributor Author

skahack commented Apr 13, 2014

Thank you for your review.
I fixed this branch.

@bhuga
Copy link
Contributor

bhuga commented Apr 14, 2014

Thanks for the fix!

bhuga pushed a commit that referenced this pull request Apr 14, 2014
@bhuga bhuga merged commit 12f0cac into atom:master Apr 14, 2014
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yanking and putting near the bottom of a file doesn't work properly
2 participants