-
Notifications
You must be signed in to change notification settings - Fork 250
Conversation
Is this still needed after #198 landed? Sorry it took me a few days to get to it. |
Yes.
keydown: jjyyp result:
keydown: yyjp result:
|
Ah,, Sorry, I did not notice in the merged #198 Please try below.
keydown: jyyjp result:
keydown: jyyp result:
keydown: jjyyP
|
Can merge master/rebase please? |
ok, I rebased. |
Okay, I see the remaining issues. Taking this for a spin now. |
expect(editor.getCursorScreenPosition()).toEqual [1, 1] | ||
|
||
describe "at the middle line", -> | ||
beforeEach -> | ||
vimState.setRegister('"', text: " 456\n", type: 'linewise') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really want an integration test of the issues you're solving. Something that sets up an editor, yanks a line, moves, and pastes it. This test will continue to work if we broke the behavior of yank to not include a newline or something silly like that.
I need to run out now, but after playing with this it looks like all the problems are fixed. If you can clean up the one or two nitpicks I had I'll get this merged tonight. Would be awesome to finally put this to bed. |
Thank you for your review. |
Thanks for the fix! |
fix put-operation
Fix #195 issue.