Skip to content
This repository has been archived by the owner on Apr 6, 2018. It is now read-only.

Navigation for tree-view #950

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Navigation for tree-view #950

merged 1 commit into from
Mar 10, 2016

Conversation

SchDen
Copy link
Contributor

@SchDen SchDen commented Jan 15, 2016

Vim mode way navigation in atom/tree-view

Vim mode way navigation in [atom/tree-view](https://github.com/atom/tree-view)
@lee-dohm
Copy link
Contributor

@donokuda Can you take a quick look at this and let me know what you think?

@donokuda
Copy link

@lee-dohm Just tried out @SchDen's patch and it works as I would expect it to 🙌

@lee-dohm
Copy link
Contributor

@SchDen Can you investigate the build break and see if it has anything to do with your change?

@SchDen
Copy link
Contributor Author

SchDen commented Jan 28, 2016

Ok. I try it

@SchDen
Copy link
Contributor Author

SchDen commented Jan 28, 2016

@lee-dohm please prompt to me.. How i can run tests for test my changes?

@50Wliu
Copy link
Contributor

50Wliu commented Jan 28, 2016

@SchDen apm install and then apm test inside of the tree-view folder.

@SchDen
Copy link
Contributor Author

SchDen commented Jan 29, 2016

@50Wliu oh yep, thanks!

@SchDen
Copy link
Contributor Author

SchDen commented Jan 29, 2016

Hi gays!

I make 4 steps for tests it

  • Clone tree-view form atom/tree-view
  • Make apm install
  • Make apm test (Tests passed)
  • Add hotkeys to keymaps/tree-view.cson
  • Make apm install
  • Make apm test (Tests passed)

Fist start tests
step1

Second start tests
step2

@jontonsoup
Copy link

any update on this? I'd love to help -- great feature :)

@lee-dohm
Copy link
Contributor

Thanks for the ping @jontonsoup (great username by the way 😀) I completely lost track of this. Can you test this out and see if it works as you expect?

@jontonsoup
Copy link

@lee-dohm haha thanks -- will do

@jontonsoup
Copy link

@lee-dohm works perfectly for me. Not sure why the tests are broken, though.

I was actually confused and thought the feature was navigation between panes and between the tree without clicking (Similar to how nerd tree works with real vim). Do you know if this is possible?

@lee-dohm
Copy link
Contributor

Yes, it is possible with Ctrl+0 on OS X or Alt+</kbd> on other platforms by default. Not sure if there is a vim-mode way to do it though.

lee-dohm added a commit that referenced this pull request Mar 10, 2016
Navigation for tree-view
@lee-dohm lee-dohm merged commit 8d157f4 into atom:master Mar 10, 2016
@lee-dohm
Copy link
Contributor

Thanks @SchDen for your hard work on this ... sorry it took so long!

@jontonsoup
Copy link

@lee-dohm Should i move this convo to a new issue? I'd like to map this to Ctrl+H and Ctrl+L

The square vim distro is an example of this: https://github.com/square/maximum-awesome

@lee-dohm
Copy link
Contributor

Yes, a new issue would be appreciated. Please @mention me there 😀

@SchDen
Copy link
Contributor Author

SchDen commented Mar 25, 2016

@lee-dohm thanks!
I saw it just)))

@gerrywastaken
Copy link

gerrywastaken commented Jun 10, 2016

Is the most up to date changelog on master? Should there be a mention of this change and how it works?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants