Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring errors in __init__.py #18

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Fix docstring errors in __init__.py #18

merged 2 commits into from
Jun 28, 2021

Conversation

timcallow
Copy link
Contributor

Fixes the warnings:

docerrors_screenshot

@timcallow timcallow mentioned this pull request Jun 27, 2021
Closed
DanielKotik
DanielKotik approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@DanielKotik DanielKotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Fixing the two small issues, and the PR can be merged.:)

atoMEC/__init__.py Outdated Show resolved Hide resolved
atoMEC/__init__.py Outdated Show resolved Hide resolved
timcallow
timcallow commented Jun 28, 2021
View reviewed changes
Copy link
Contributor Author

@timcallow timcallow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finds @DanielKotik

@timcallow @DanielKotik
Apply suggestions from code review
0bb7c75 
Co-authored-by: Daniel Kotik <d.kotik@hzdr.de>
@timcallow timcallow merged commit 73efb2f into documentation Jun 28, 2021
@timcallow timcallow deleted the fix_docs_in_init branch June 28, 2021 07:34
@timcallow timcallow mentioned this pull request Jun 28, 2021
Merged
@DanielKotik DanielKotik mentioned this pull request Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielKotik DanielKotik DanielKotik approved these changes

Assignees

@DanielKotik DanielKotik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timcallow @DanielKotik