#216 monorepo app assets

.vscode/recommendations.json

@@ -1,5 +1,10 @@
 {
   "recommendations": [
-    "matklad.rust-analyzer"
+    "matklad.rust-analyzer",
+    "sakamoto66.vscode-playwright-test-runner",
+    "ms-vscode.vscode-typescript-next",
+    "dbaeumer.vscode-eslint",
+    "antfu.vite",
+    "ms-playwright.playwright"
   ]
 }

.vscode/settings.json

@@ -2,5 +2,38 @@
   // The linter in the CI is quite strict, so running `cargo fmt` on save is probably a good idea!
   "editor.formatOnSave": true,
   "files.autoSave": "onFocusChange",
-  "rust-analyzer.checkOnSave.command": "clippy"
+  "rust-analyzer.checkOnSave.command": "clippy",
+  "editor.rulers": [
+    80
+  ],
+  "search.exclude": {
+    "**/.git": true,
+    "**/node_modules": true,
+    "**/build": true,
+    "**/coverage": true,
+    "**/dist": true,
+  },
+  "eslint.validate": [
+    "javascript",
+    "javascriptreact",
+    "typescript",
+    "typescriptreact"
+  ],
+  "typescript.preferences.importModuleSpecifierEnding": "minimal",
+  "eslint.alwaysShowStatus": true,
+  "eslint.format.enable": true,
+  "eslint.lintTask.enable": true,
+  "eslint.packageManager": "pnpm",
+  "eslint.quiet": true,
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true,
+  },
+  "jest.enableInlineErrorMessages": true,
+  "jest.showCoverageOnLoad": true,
+  "jest.runAllTestsFirst": false,
+  "eslint.workingDirectories": [
+    "./data-browser",
+    "./react",
+    "./lib"
+  ]
 }

.vscode/tasks.json

@@ -55,6 +55,30 @@
 			"command": "docker run -d -e COLLECTOR_ZIPKIN_HTTP_PORT=9411 -p 5775:5775/udp -p 6831:6831/udp -p 6832:6832/udp -p 5778:5778 -p 16686:16686 -p 14268:14268 -p 9411:9411 jaegertracing/all-in-one",
 			"group": "none",
 			"problemMatcher": []
-		}
+		},
+		{
+			"type": "npm",
+			"script": "start",
+			"problemMatcher": [
+				"$tsc-watch"
+			],
+			"label": "run data-browser dev server (pnpm start)",
+			"detail": "pnpm workspace @tomic/data-browser start",
+			"isBackground": true,
+			"path": "browser",
+			"group": "build"
+		},
+		{
+			"type": "npm",
+			"script": "test",
+			"problemMatcher": [
+				"$tsc-watch"
+			],
+			"label": "test data-browser",
+			"path": "browser",
+			"detail": "pnpm test",
+			"isBackground": true,
+			"group": "test"
+		},
 	]
 }

CONTRIBUTE.md

@@ -28,7 +28,6 @@ Check out the [Roadmap](https://docs.atomicdata.dev/roadmap.html) if you want to
   - [Drill](#drill)
 - [Responsible disclosure / Coordinated Vulnerability Disclosure](#responsible-disclosure--coordinated-vulnerability-disclosure)
 - [Releases, Versioning and Tagging](#releases-versioning-and-tagging)
-  - [Including JS app\_assets](#including-js-app_assets)
   - [Publishing manually - doing the CI's work](#publishing-manually---doing-the-cis-work)
     - [Building and publishing binaries](#building-and-publishing-binaries)
     - [Publishing to Cargo](#publishing-to-cargo)
@@ -188,16 +187,6 @@ Note:
   - The version for `atomic-lib` is the most important, and dictates the versions of `cli` and `server`. When `lib` changes minor version, `cli` and `server` should follow.
   - After publishing, update the `./desktop/latest-version.json` file. This is used for auto-updating desktop distributions. See [tauri docs](https://tauri.studio/docs/distribution/updater).
 
-### Including JS app_assets
-
-Before tagging a new version, make sure to update the `app_assets` folder:
-
-1. Go up one directory from `atomic-server` => `cd ..`
-2. In here, clone [atomic-data-browser](https://github.com/atomicdata-dev/atomic-data-browser)
-3. Run `./build-server.sh` to compile assets and copy them to your `app_assets` directory
-4. Make sure not to commit all the files, manually check them
-5. search and replace `.workbox` with `./app_assets/workbox` in `sw.js`, because we'll host `sw.js` from root.
-
 ### Publishing manually - doing the CI's work
 
 If the CI scripts for some reason do not do their job (buildin releases, docker file, publishing to cargo), you can follow these instructions:

browser/.vscode/tasks.json

@@ -1,34 +1,4 @@
 {
 	"version": "2.0.0",
-	"tasks": [
-		{
-			"type": "npm",
-			"script": "start",
-			"problemMatcher": [
-				"$tsc-watch"
-			],
-			"label": "run data-browser dev server (pnpm start)",
-			"detail": "pnpm workspace @tomic/data-browser start",
-			"isBackground": true,
-			"group": "build"
-		},
-		{
-			"type": "npm",
-			"script": "test",
-			"problemMatcher": [
-				"$tsc-watch"
-			],
-			"label": "test data-browser",
-			"detail": "pnpm test",
-			"isBackground": true,
-			"group": "test"
-		},
-		{
-			"type": "shell",
-			"command": "./build_server.sh",
-			"label": "build server JS assets",
-			"isBackground": true,
-			"group": "build"
-		}
-	]
+	"tasks": []
 }