Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check signatures before applying commit #27

Closed
2 tasks done
joepio opened this issue Oct 10, 2020 · 3 comments
Closed
2 tasks done

Check signatures before applying commit #27

joepio opened this issue Oct 10, 2020 · 3 comments

Comments

@joepio
Copy link
Member

joepio commented Oct 10, 2020

atomicdata-dev/atomic-data-docs#14

Also relates to #13 and #26

Following implementations required:

  • serialize_deterministically to generate a string that can be used to
  • validate_signature function on Commit, using serialize_deterministically and a public key from an Atomic Author.
@joepio
Copy link
Member Author

joepio commented Oct 18, 2020

We need some form of cryptographic signatures. I think the ring library is pretty good - many people use it, and the API is well documented.

@joepio
Copy link
Member Author

joepio commented Oct 18, 2020

In order to validate signatures, the Actor must be available at some endpoint. This Actor should contain a public key. The private key needs to be available for the one creating the commit.

joepio added a commit that referenced this issue Oct 19, 2020
@joepio
Copy link
Member Author

joepio commented Oct 19, 2020

Made some real progress on signing. Deterministic serialization is next!

joepio added a commit that referenced this issue Oct 25, 2020
@joepio joepio closed this as completed Oct 25, 2020
joepio added a commit that referenced this issue Oct 25, 2020
joepio added a commit that referenced this issue Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant