-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored form #20
Refactored form #20
Conversation
@@ -13,18 +12,13 @@ function select(state) { | |||
}; | |||
} | |||
|
|||
export class Home extends React.Component { | |||
export class Index extends React.Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component should be written as a pure function react/prefer-stateless-function
checked: React.PropTypes.bool, | ||
name: React.PropTypes.string, | ||
type: React.PropTypes.string.isRequired, | ||
onChange: React.PropTypes.func, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'inputProps.onChange' PropType is defined but prop is never used react/no-unused-prop-types
id: React.PropTypes.string, | ||
value: React.PropTypes.string, | ||
checked: React.PropTypes.bool, | ||
name: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'inputProps.name' PropType is defined but prop is never used react/no-unused-prop-types
inputProps: React.PropTypes.shape({ | ||
id: React.PropTypes.string, | ||
value: React.PropTypes.string, | ||
checked: React.PropTypes.bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'inputProps.checked' PropType is defined but prop is never used react/no-unused-prop-types
labelText: React.PropTypes.string, | ||
inputProps: React.PropTypes.shape({ | ||
id: React.PropTypes.string, | ||
value: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'inputProps.value' PropType is defined but prop is never used react/no-unused-prop-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
No description provided.