-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests #29
Conversation
@@ -17,6 +17,6 @@ export default function Header(props) { | |||
Header.propTypes = { | |||
newApplicationInstance: React.PropTypes.func.isRequired, | |||
application: React.PropTypes.shape({ | |||
// name: React.PropTypes.string, | |||
name: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'application.name' PropType is defined but prop is never used react/no-unused-prop-types
Should these settings be fixed as well? From camelCase to snake_case?
|
Yes those should be fixed as well. I'll do that. |
Changes Unknown when pulling 4102001 on tests into ** on master**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Adds missing tests