Fix stats calculation for currency count (#362)

atomiclabs · Jun 19, 2018 · 29c6e91 · 29c6e91
1 parent 20fec1d
commit 29c6e91
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/app/renderer/swap-db.js b/app/renderer/swap-db.js
@@ -248,9 +248,10 @@ class SwapDB {
 		const swaps = await this.getSwaps({since: timestamp});
 		const successfulSwaps = swaps.filter(swap => swap.status === 'completed');
 
-		const quoteCurrencies = new Set();
+		const tradedCurrencies = new Set();
 		for (const swap of successfulSwaps) {
-			quoteCurrencies.add(swap.quoteCurrency);
+			tradedCurrencies.add(swap.baseCurrency);
+			tradedCurrencies.add(swap.quoteCurrency);
 		}
 
 		let totalSwapsWorthInUsd = 0;
@@ -260,7 +261,7 @@ class SwapDB {
 
 		return {
 			successfulSwapCount: successfulSwaps.length,
-			currencyCount: quoteCurrencies.size,
+			currencyCount: tradedCurrencies.size,
 			totalSwapsWorthInUsd,
 		};
 	}

diff --git a/app/renderer/views/Trades.js b/app/renderer/views/Trades.js
@@ -67,7 +67,7 @@ const Trades = props => (
 						</nav>
 						<div className="stats">
 							{stats &&
-								<p>In the last month you did {stats.successfulSwapCount} successful {stats.successfulSwapCount === 1 ? 'trade' : 'trades'} for {stats.currencyCount} {stats.currencyCount === 1 ? 'currency' : 'currencies'} worth {formatCurrency(stats.totalSwapsWorthInUsd)} in total</p>
+								<p>In the last month you did {stats.successfulSwapCount} successful {stats.successfulSwapCount === 1 ? 'trade' : 'trades'} in {stats.currencyCount} {stats.currencyCount === 1 ? 'currency' : 'currencies'} worth {formatCurrency(stats.totalSwapsWorthInUsd)} in total</p>
 							}
 						</div>
 					</header>