Fix number inputs #333
Merged
Fix number inputs #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, React is just broken when it comes to number inputs. The fix is to just use normal string based inputs. I also added some validation for number inputs.
sindresorhus
force-pushed
the
fix-number-inputs
branch
from
3a14502
to
180204d
Compare
|
Sorry, accidental close. When I checkout this branch I can't log in. As soon as I enter a char for my password it sets the input value as |
Oops, fixed. |
lukechilds
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, React is totally broken when it comes to number inputs. The fix is to just use normal string based inputs. I also added some validation for number inputs.
I also changed the withdraw modal to use separate states for the amount and the amount in USD. That's the only way to make it work.
tl;dr Numbers are hard