Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display order failures using a system notification #339

Merged
merged 3 commits into from
Jun 5, 2018

Conversation

sindresorhus
Copy link
Contributor

Also shake the button.

shake

screen shot 2018-06-04 at 19 07 59

Fixes #328

@lukechilds
Copy link
Member

This so much better than the ugly errors before!

Only slight nit is that the shake looks a bit over exaggerated to me.

What do you think about reducing the amount of shakes, the distance of the shake, and increasing the speed? So it's more of a wriggly jitter than a smooth shake.

Current:

Less exaggerated:

Didn't wanna commit without your feedback but diff is here if you like it:

diff --git a/app/renderer/styles/index.scss b/app/renderer/styles/index.scss
index edb809b6..5deb3f6c 100644
--- a/app/renderer/styles/index.scss
+++ b/app/renderer/styles/index.scss
@@ -196,22 +196,17 @@ th {
 		transform: translate3d(0, 0, 0);
 	}
 
-	10%,
-	30%,
-	50%,
-	70%,
-	90% {
-		transform: translate3d(-10px, 0, 0);
+	20%,
+	60% {
+		transform: translate3d(-5px, 0, 0);
 	}
 
-	20%,
 	40%,
-	60%,
 	80% {
-		transform: translate3d(10px, 0, 0);
+		transform: translate3d(5px, 0, 0);
 	}
 }
 
 .shake-animation {
-	animation: shake 0.8s ease;
+	animation: shake 0.3s ease;
 }

@sindresorhus
Copy link
Contributor Author

@lukechilds Looks much better. My wife commented on it being to exaggerated too.

@sindresorhus sindresorhus merged commit 621d934 into master Jun 5, 2018
@sindresorhus sindresorhus deleted the notification-on-order-fail branch June 5, 2018 09:50
@lukechilds
Copy link
Member

Your wife has good taste in UI animations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants