-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Printing the url list to txt file with output-file
#10
Conversation
The requirement here is met. #4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the pull request!
I have added some small change requests but otherwise it looks good! Great job :)
When I get to the computer, I will ask about the necessary corrections and what some of the requirements mean in detail. Thanks @atomicptr |
I also updated the readme and help sections. There will be no such problem. Thanks for the information and collaboration. @atomicptr Best regards from Turkey |
There seems to be a problem with the records after scanning large xml files :( Seems like it could solve this problem: if data["status"] != nil || data["url"] != nil || data["time"] != nil || data["duration"] != nil {
status = data["status"].(float64)
url = data["url"].(string)
time = data["time"].(float64)
duration = data["duration"].(float64)
_, err = file.WriteString(fmt.Sprintf("%d\t%s\t%d\t%d", int(status), url, int(time), int(duration)) + "\n")
} else {
_, err = file.WriteString(message + "\n")
} I may need some time to make sure the code works. |
Thanks for the changes, I found a few more things but otherwise it looks great :) |
I have completed the final changes required. I am updating the code and sending it. @atomicptr |
whoops something went wrong here 👀 |
I kinda fucked something up by using a gh cli tool not quite sure what yet although I merged the changes with #11 Thank you very much for the PR! :) |
Thanks for the fixes and Merge. @atomicptr |
upd: The url list of all request is saved in the
./output/output.txt
file.feat: Print query results as array with
output-json
upg: Dependencies upgraded.
upd: Readme new flags added.
I also checked it with 17k rows of data. It worked flawlessly.
I hope I made bad code. I recently started working to improve myself in Go. Thanks @atomicptr