fix not working interactive option #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tippy content is inside a shadow dom, the `interactive` option is not working. The reason is > Events that happen in shadow DOM have the host element as the target, when caught outside of the component. the popper is inside the host, so `popper.contains(target)` will always return false. see https://javascript.info/shadow-dom-events by using `event.composedPath` instead of the `event.target`, it will get the actual target and fix this bug. see https://stackoverflow.com/questions/39245488/event-path-is-undefined-running-in-firefox/39245638#39245638
|
Thank you! |
zhaoyao91
added a commit
to zhaoyao91/tippyjs
that referenced
this pull request
Mar 2, 2021
the following fix of atomiks#913 in `onDocumentPress`, the check for `event.target` should all be replaced with `actualTarget`.
Merged
atomiks
pushed a commit
that referenced
this pull request
Mar 2, 2021
the following fix of #913 in `onDocumentPress`, the check for `event.target` should all be replaced with `actualTarget`.
junglerot
pushed a commit
to junglerot/jungle
that referenced
this pull request
Feb 3, 2024
the following fix of atomiks/tippyjs#913 in `onDocumentPress`, the check for `event.target` should all be replaced with `actualTarget`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tippy content is inside a shadow dom, the
interactiveoption is not working.The reason is
the popper is inside the host, so
popper.contains(target)will always return false.see https://javascript.info/shadow-dom-events
by using
event.composedPathinstead of theevent.target, it will get the actual target and fix this bug.see https://stackoverflow.com/questions/39245488/event-path-is-undefined-running-in-firefox/39245638#39245638