Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix not working interactive option #913

Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix not working interactive option #913

merged 1 commit into from
Mar 1, 2021

Commits on Mar 1, 2021

  1. fix not working interactive option 

    When tippy content is inside a shadow dom, the `interactive` option is not working.

The reason is 
> Events that happen in shadow DOM have the host element as the target, when caught outside of the component.
the popper is inside the host, so `popper.contains(target)` will always return false.
see https://javascript.info/shadow-dom-events

by using `event.composedPath` instead of the `event.target`, it will get the actual target and fix this bug.

see https://stackoverflow.com/questions/39245488/event-path-is-undefined-running-in-firefox/39245638#39245638
    @zhaoyao91
    zhaoyao91 authored Mar 1, 2021
    Configuration menu
    Copy the full SHA
    79ac990 View commit details
    Browse the repository at this point in the history