Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce createGoals on SDM #183

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Introduce createGoals on SDM #183

merged 1 commit into from
Jul 8, 2019

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Jul 5, 2019

This PR adds support to use createGoals function on the SDM instance inside configure:

export interface SpringGoals extends AllGoals {
    autofix: Autofix;
    version: Version;
    codeInspection: AutoCodeInspection;
    pushImpact: PushImpact;
    build: Build;
    dockerBuild: DockerBuild;
}

export const configuration = configure<SpringGoals>(async sdm => {

    const goals = await sdm.createGoals(SpringGoalCreator, SpringGoalConfigurer);

    return {
        check: {
            test: IsMaven,
            goals: [
                [goals.cancel, goals.autofix],
                [goals.codeInspection, goals.version, goals.fingerprint, goals.pushImpact],
            ],
        },
    ...
    };
});

This is entirely optional to use and backwards compatible.

@cdupuis cdupuis requested a review from ddgenome July 5, 2019 08:22
@cdupuis cdupuis added auto-merge-method:merge Auto-merge with merge commit auto-merge:on-approve Auto-merge on review approvals changelog:added Add this issue or pull request to added changelog section enhancement New feature or request auto-rebase:on-push Auto-rebase pull request branch labels Jul 5, 2019
@cdupuis
Copy link
Member Author

cdupuis commented Jul 5, 2019

Removing auto-merge labels for now as I want to make some minor tweaks.

@cdupuis cdupuis removed auto-merge-method:merge Auto-merge with merge commit auto-merge:on-approve Auto-merge on review approvals labels Jul 5, 2019
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No hard suggestions, just things to consider.

lib/machine/configure.ts Show resolved Hide resolved
lib/machine/configure.ts Outdated Show resolved Hide resolved
lib/machine/configure.ts Outdated Show resolved Hide resolved
lib/machine/configure.ts Outdated Show resolved Hide resolved
@cdupuis
Copy link
Member Author

cdupuis commented Jul 7, 2019

Pull request was successfully rebased onto df3f4aa by @cdupuis:

@cdupuis
Copy link
Member Author

cdupuis commented Jul 7, 2019

Pull request was successfully rebased onto 5947a5f by @atomist-bot:

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch 2 times, most recently from e9bc019 to 228e650 Compare July 7, 2019 20:39
@cdupuis
Copy link
Member Author

cdupuis commented Jul 8, 2019

Pull request was successfully rebased onto 2f723d5 by @cdupuis:

  • 0c3caff Polish
  • 2f723d5 Fix label selector for time based job deletion

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch 2 times, most recently from d13668b to d14f1a4 Compare July 8, 2019 09:46
@cdupuis
Copy link
Member Author

cdupuis commented Jul 8, 2019

Pull request was successfully rebased onto 8238b3a by @cdupuis:

@cdupuis
Copy link
Member Author

cdupuis commented Jul 8, 2019

Pull request was successfully rebased onto 7255764 by @cdupuis:

  • 7255764 Use configuration passed into initialize

@cdupuis
Copy link
Member Author

cdupuis commented Jul 8, 2019

Pull request was successfully rebased onto f103285 by @cdupuis:

@cdupuis cdupuis requested a review from ddgenome July 8, 2019 13:14
@cdupuis cdupuis added auto-merge-method:merge Auto-merge with merge commit auto-merge:on-approve Auto-merge on review approvals labels Jul 8, 2019
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdupuis
Copy link
Member Author

cdupuis commented Jul 8, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@cdupuis cdupuis merged commit dd99673 into master Jul 8, 2019
@cdupuis cdupuis deleted the create-goals-on-sdm branch July 8, 2019 13:17
cdupuis pushed a commit that referenced this pull request Jul 8, 2019
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit auto-rebase:on-push Auto-rebase pull request branch changelog:added Add this issue or pull request to added changelog section enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants