Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PreferenceStore implementations #93

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Add PreferenceStore implementations #93

merged 1 commit into from
Jan 15, 2019

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Jan 15, 2019

No description provided.

@cdupuis cdupuis requested a review from johnsonr January 15, 2019 12:29
@cdupuis cdupuis added changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals labels Jan 15, 2019
@cdupuis cdupuis requested review from ddgenome and removed request for johnsonr January 15, 2019 12:30
ddgenome
ddgenome reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

lib/internal/preferences/FilePreferenceStore.ts Outdated Show resolved Hide resolved
lib/internal/preferences/FilePreferenceStore.ts Outdated Show resolved Hide resolved
lib/internal/preferences/FilePreferenceStore.ts Outdated Show resolved Hide resolved
lib/internal/preferences/FilePreferenceStore.ts Outdated Show resolved Hide resolved
lib/internal/preferences/AbstractPreferenceStore.ts Show resolved Hide resolved
test/internal/preferences/preferences.test.ts Outdated Show resolved Hide resolved
test/internal/preferences/preferences.test.ts Outdated Show resolved Hide resolved
ddgenome
ddgenome approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did the change to make things optional in sdm affect any of these changes?

@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit e5f958a into master Jan 15, 2019
@atomist-bot atomist-bot deleted the pref-store branch January 15, 2019 22:42
atomist-bot added a commit that referenced this pull request Jan 15, 2019
@atomist-bot
Changelog: #93 to added
de3e55f 
[atomist:generated]
@cdupuis
Copy link
Member Author

cdupuis commented Jan 15, 2019

LGTM. Did the change to make things optional in sdm affect any of these changes?

No, the options were already defaulting to always set a preferences instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddgenome ddgenome ddgenome approved these changes

Assignees
No one assigned
Labels
auto-merge:on-approve Auto-merge on review approvals changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdupuis @atomist-bot @ddgenome