Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PreferenceStore implementations #93

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
3 participants
@cdupuis
Copy link
Contributor

commented Jan 15, 2019

No description provided.

@cdupuis cdupuis requested a review from johnsonr Jan 15, 2019

@cdupuis cdupuis requested review from ddgenome and removed request for johnsonr Jan 15, 2019

@ddgenome
Copy link
Member

left a comment

A few minor comments.

Show resolved Hide resolved lib/internal/preferences/FilePreferenceStore.ts Outdated
Show resolved Hide resolved lib/internal/preferences/FilePreferenceStore.ts Outdated
Show resolved Hide resolved lib/internal/preferences/FilePreferenceStore.ts Outdated
Show resolved Hide resolved lib/internal/preferences/FilePreferenceStore.ts Outdated
Show resolved Hide resolved lib/internal/preferences/AbstractPreferenceStore.ts
Show resolved Hide resolved test/internal/preferences/preferences.test.ts Outdated
Show resolved Hide resolved test/internal/preferences/preferences.test.ts Outdated

@cdupuis cdupuis force-pushed the pref-store branch from 27ab884 to fb42574 Jan 15, 2019

@cdupuis cdupuis force-pushed the pref-store branch from fb42574 to 48657ae Jan 15, 2019

@ddgenome
Copy link
Member

left a comment

LGTM. Did the change to make things optional in sdm affect any of these changes?

@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit e5f958a into master Jan 15, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@atomist-bot atomist-bot deleted the pref-store branch Jan 15, 2019

atomist-bot added a commit that referenced this pull request Jan 15, 2019

Changelog: #93 to added
[atomist:generated]
@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

LGTM. Did the change to make things optional in sdm affect any of these changes?

No, the options were already defaulting to always set a preferences instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.