-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targets.branch
to CodeTransform
targeting
#636
Conversation
targets.branch
to CodeTransform
targetting
targets.branch
to CodeTransform
targettingtargets.branch
to CodeTransform
targeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(leaving as comment so it doesn't get merged until the automation-client PR)
package.json
Outdated
@@ -54,7 +54,7 @@ | |||
"@atomist/slack-messages": ">=1.1.0" | |||
}, | |||
"devDependencies": { | |||
"@atomist/automation-client": "^1.1.0", | |||
"@atomist/automation-client": "1.2.0-generate-repo-id.20181220113107", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait until atomist/automation-client#434 has been merged and use that version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just did that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Pull request auto merged by Atomist.
[atomist:generated] [auto-merge:on-approve] |
Add
targets.branch
toCodeTransform
targeting parameter classes.The actual support for this is mostly in atomist/automation-client#434.