Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targets.branch to CodeTransform targeting #636

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Dec 20, 2018

Add targets.branch to CodeTransform targeting parameter classes.

The actual support for this is mostly in atomist/automation-client#434.

@cdupuis cdupuis changed the title Add targets.branch to code transforms Add targets.branch to CodeTransform targetting Dec 20, 2018
@cdupuis cdupuis added changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals labels Dec 20, 2018
@cdupuis cdupuis changed the title Add targets.branch to CodeTransform targetting Add targets.branch to CodeTransform targeting Dec 20, 2018
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(leaving as comment so it doesn't get merged until the automation-client PR)

package.json Outdated
@@ -54,7 +54,7 @@
"@atomist/slack-messages": ">=1.1.0"
},
"devDependencies": {
"@atomist/automation-client": "^1.1.0",
"@atomist/automation-client": "1.2.0-generate-repo-id.20181220113107",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait until atomist/automation-client#434 has been merged and use that version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just did that.

@cdupuis cdupuis added the auto-merge-method:squash Auto-merge with squash and merge label Dec 20, 2018
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@atomist-bot atomist-bot merged commit 1e1a125 into master Dec 20, 2018
@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the targets-branch branch December 20, 2018 18:46
atomist-bot added a commit that referenced this pull request Dec 20, 2018
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants