Skip to content

Commit

Permalink
Add build number to filtered resource.
Browse files Browse the repository at this point in the history
  • Loading branch information
johnou committed Aug 20, 2018
1 parent f9ed5dd commit db4d5e4
Show file tree
Hide file tree
Showing 4 changed files with 55 additions and 1 deletion.
11 changes: 10 additions & 1 deletion cluster/src/main/java/io/atomix/cluster/AtomixCluster.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@
import org.slf4j.LoggerFactory;

import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.util.Collections;
import java.util.Properties;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.stream.Stream;
Expand Down Expand Up @@ -278,7 +281,13 @@ protected CompletableFuture<Void> startServices() {

protected CompletableFuture<Void> completeStartup() {
started.set(true);
LOGGER.info("Started");
final Properties properties = new Properties();
try (final InputStream stream = getClass().getResourceAsStream("atomix.properties")) {
properties.load(stream);
} catch (IOException ignore) {
// ignore
}
LOGGER.info("Started " + properties.getProperty("atomixBuildNumber", "SNAPSHOT"));
return CompletableFuture.completedFuture(null);
}

Expand Down
13 changes: 13 additions & 0 deletions core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,20 @@
</dependencies>

<build>
<resources>
<resource>
<directory>src/main/resources</directory>
</resource>
<resource>
<directory>src/main/filtered-resources</directory>
<filtering>true</filtering>
</resource>
</resources>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>buildnumber-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
Expand Down
2 changes: 2 additions & 0 deletions core/src/main/filtered-resources/atomix.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# must be different name to avoid recursive bug in Eclipse
atomixBuildNumber=${buildNumber}
30 changes: 30 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,36 @@
</dependencies>

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>buildnumber-maven-plugin</artifactId>
<version>1.4</version>
<configuration>
<revisionOnScmFailure>N/A</revisionOnScmFailure>
<format>{0} (revision {1} built on {2,date,yyyy-MM-dd HH:mm:ss})</format>

This comment has been minimized.

Copy link
@johnou

johnou Aug 20, 2018

Author Member

looks like this 7.0.128 (revision e4c8d3 built on 2018-08-13 13:15:09)

<items>
<item>${project.version}</item>
<item>scmVersion</item>
<item>timestamp</item>
</items>
<shortRevisionLength>6</shortRevisionLength>
<doCheck>false</doCheck>
<doUpdate>false</doUpdate>
</configuration>
<executions>
<execution>
<id>configure-buildnumber</id>
<phase>validate</phase>
<goals>
<goal>create</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down

0 comments on commit db4d5e4

Please sign in to comment.