Fix negative unaries - Take 2 #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawildoer
commented
Apr 26, 2024
| ; | ||
|
|
||
| factor |
There was a problem hiding this comment.
This will mean that you can't put a unary in front of brackets or variables
mawildoer
commented
Apr 26, 2024
| bilateral_quantity: bilateral_nominal PLUS_OR_MINUS bilateral_tolerance; | ||
| implicit_quantity: NUMBER name?; | ||
| bilateral_nominal: NUMBER name?; | ||
| bound_quantity: quantity 'to' quantity; |
There was a problem hiding this comment.
Do we want to make tolerances (especially the to operator) part of the nesting arithmetic expressions rather than a part of an atom
mawildoer
deleted the
revert-317-revert-314-mawildoer/negative-assertions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as #314 , except it should actually work...