Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding hasText method #31

Merged
merged 2 commits into from
Apr 10, 2013
Merged

adding hasText method #31

merged 2 commits into from
Apr 10, 2013

Conversation

omansour
Copy link

@omansour omansour commented Apr 2, 2013

Used to quickly check if a response contain a text

@kennydee
Copy link

kennydee commented Apr 3, 2013

👍

@FlorianLB
Copy link
Member

Thx for your PR.

Just few comments :

  • can you implement the fail message in the same way that other methods ?
  • i think the name "hasText" can be in conflict with "hasContent". Not easy to see the difference between both. What about "contains"/"containsText" or something like that ?
  • unit tests would be great if you have time ^^

@omansour
Copy link
Author

omansour commented Apr 3, 2013

ok I will do that

@stephpy
Copy link
Member

stephpy commented Apr 3, 2013

👍

@omansour
Copy link
Author

still missing time for writing the test ... damnit

FlorianLB added a commit that referenced this pull request Apr 10, 2013
@FlorianLB
Merge pull request #31 from omansour/master
048f22b 
adding contains method to response asserter
@FlorianLB FlorianLB merged commit 048f22b into atoum:master Apr 10, 2013
@FlorianLB
Copy link
Member

Thx ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omansour @kennydee @FlorianLB @stephpy