atoum exits when the bootstrap fails

[Hywan]

Hello fellow atoum hackers,

I faced an issue today. On a code we don't control entirely, the PHP version has been updated. PHP now emits errors for undefined constants. That's expect, everything is normal. However, we can't run the tests anymore because atoum exits before running the tests, as defined here:

atoum/classes/scripts/runner.php

Lines 691 to 699 in b25d916

	set_error_handler(function ($error, $message, $file, $line) use ($autorunner) {
	$errorReporting = error_reporting();
	if ($errorReporting !== 0 && $errorReporting & $error) {
	$autorunner->writeError($message . ' in ' . $file . ' at line ' . $line, $error);
	exit(3);
	}
	});

Maybe it's not a good idea to exit the process directly. Logging a message is enough I think. It's very likely that the errors will be reported by the tests too. In our situation, we prefer to see the tests running, and use reports to see the errors, than not being able to run the tests.

Thoughts?

cc @jubianchi @Grummfy

[Grummfy]

as I know it exit from the test and that's all, no? Otherwie we have a behaviour not coherent with the other exit, no?

[Hywan]

No, it exits if a bootsrap error happens. For an error raised during a test executed, it's reported as is, and the runner continues to execute tests.