Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pygamer usb #104

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Pygamer usb #104

merged 3 commits into from
Nov 19, 2019

Conversation

jacobrosenthal
Copy link
Member

Neopixel example wasn't working for me at all.. I reved the underlying deps and now it works for 1 led but not more. I'll pr that work over there as well.

Then I brought over usb from metro_m4. (likewise its stuck on 1 lets as well)
The only problem there is uart_debug.rs is pretty coupled and needs a better solution than this.

@twitchyliquid64
Copy link
Contributor

Yeah uart_debug is 🔥 🗑️ - couldn't work out a better way to do it :( feel free to revise or maybe even rip it out.

Maybe it makes more sense being in the uart code? That way there can be an invariant for each kind of uart rather than the one on the itsybitsy_m4 pins.

@twitchyliquid64
Copy link
Contributor

now it works for 1 led but not more.

Neopixel or apa102 LED?

@twitchyliquid64
Copy link
Contributor

I didn't think neopixels were compatible with SPI? I thought they had to be bitbanged?

@jacobrosenthal
Copy link
Member Author

Neopixels. And yes theyre being bitbanged using the same library as the itsy bitsy

@jacobrosenthal
Copy link
Member Author

Rather the feather m4 and metro m4

@jacobrosenthal
Copy link
Member Author

RE uart_debug, the main issue is I think my stuff is on sercom5 instead of 3, so hardcoded pins need changing. I suppose we can store via traits somehow. What about static dyn like the singleton pattern docs https://docs.rust-embedded.org/embedonomicon/singleton.html

@jacobrosenthal jacobrosenthal changed the title Pygamer updates Pygamer usb Nov 18, 2019
@jacobrosenthal
Copy link
Member Author

Ive pulled all the smart-leds neopixel code out of here and its already been merged, so now this is just the usb work.

I pulled the uart_debug feature because I dont know how to fix it yet either..

Technically this could merge any time. It works as well as the other implementation

despite the existing bug #105

@jacobrosenthal jacobrosenthal marked this pull request as ready for review November 19, 2019 00:36
@sajattack sajattack merged commit bc18352 into atsamd-rs:master Nov 19, 2019
@jacobrosenthal jacobrosenthal deleted the pygamer branch January 25, 2020 19:36
kaizensparc pushed a commit to kaizensparc/atsamd that referenced this pull request Dec 24, 2021
* blinky

* usb_serial for pygamer, not being flushed until serial close

* usb_poll for pygamer, not being flushed until serial close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants