This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
1 integrate passport GitHub auth #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per. fixed issues with an error occuring even if the user was authenticated.
…res users are part of the ats org.
… latest. Merge branch 'master' into 1-integrate-passport-github-auth
| failureCallback: '/auth/failure' | ||
| }, | ||
| session: { | ||
| secret: 'keyboard cat', |
There was a problem hiding this comment.
Is this useful for anyone forking the app, or should it be pulled out as an env variable?
There was a problem hiding this comment.
Should maybe do something like process.env.SESSION_SECRET || 'keyboard cat'.
…passport init for testing when using mocks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1 by adding passport integration and requiring github authentication and membership in a specific configurable org.