addressing some concerns in the pull request comment and adding mock …

…passport init for testing when using mocks.

app/client/src/modules/app/index.js

@@ -23,7 +23,7 @@ module.exports =
     .config(function ($urlRouterProvider, $httpProvider) {
         $urlRouterProvider.otherwise('/');
         $httpProvider.interceptors.push('authInterceptor');
-    }).factory('authInterceptor', function ($rootScope, $q, $location) {
+    }).factory('authInterceptor', function ($q, $location) {
         return {
             responseError(response) {
                 if (response.status === 401) {

app/server/components/repositories/users.js

@@ -27,8 +27,8 @@ module.exports = {
         });
     },
 
-    isMember (username) {
-        return userUtil.isMember(username).then(function (data) {
+    isOrgMember (username) {
+        return userUtil.isOrgMember(username).then(function (data) {
             return "204 No Content" === data.meta.success;
         });
     }

app/server/components/repositories/util/users.js

@@ -25,8 +25,8 @@ module.exports = {
         return provider.github.getUsers(args).then(users => users.map(user => convertGithubUser(user)));
     },
 
-    isMember(username) {
-        return provider.github.isMember({
+    isOrgMember(username) {
+        return provider.github.isOrgMember({
             org: provider.github.config.org,
             username: username
         });

app/server/components/services/github.js

@@ -34,7 +34,7 @@ module.exports = {
     config: {
         org: org
     },
-    isMember: Bluebird.promisify(github.orgs.getMember),
+    isOrgMember: Bluebird.promisify(github.orgs.getMember),
     getUsers: Bluebird.promisify(github.orgs.getMembers),
     getUser: Bluebird.promisify(github.user.getFrom),
     getRepos: Bluebird.promisify(github.repos.getFromOrg),

app/server/components/services/github.mock.js

@@ -201,5 +201,13 @@ module.exports = {
                 reject(new Error('No mock team: ' + id));
             }
         });
+    },
+
+    isOrgMember (msg) {
+        return new Promise((resolve, reject) => {
+            resolve({ meta: {
+                success: "204 No Content"
+            }});
+        });
     }
 };

app/server/main.js

@@ -17,7 +17,7 @@ exports.start = () => {
             failureCallback: '/auth/failure'
         },
         session: {
-            secret: 'keyboard cat',
+            secret: process.env.SESSION_SECRET || 'keyboard cat',
             resave: false,
             saveUninitialized: true,
             cookie: {

app/server/middleware/authenticate.js

@@ -6,7 +6,7 @@ module.exports = {
     isAuthenticated (req, res, next) {
         var authenticated = req.isAuthenticated();
 
-        if (authenticated && users.isMember(req.session.passport.user.username)) {
+        if (authenticated && users.isOrgMember(req.session.passport.user.username)) {
             next();
         } else {
             res.send(401);

app/server/mock-passport-middleware.js

@@ -0,0 +1,27 @@
+'use strict';
+
+//jscs:disable disallowDanglingUnderscores
+module.exports = {
+    initialize(mockUser) {
+        return function (req, res, next) {
+            var passport = {};
+            passport._key = 'passport';
+            passport._userProperty = 'user';
+            passport.serializeUser = (user, req, done) => {
+                done(null, user);
+            };
+            passport.deserializeUser = (user, req, done) => {
+                done(null, user);
+            };
+
+            req._passport = { instance: passport };
+            req._passport.session = { user: mockUser };
+            req.session.passport = { user: mockUser };
+
+            next();
+        };
+    },
+
+    // TODO ... PUT Mock users in a seperate file so we can tests users that are
+    mockUser: { username: "TestUser", displayName: "Test User", id: 1 }
+};

app/server/passport.js

@@ -35,10 +35,16 @@ module.exports = {
             done(null, user);
         });
 
-        app.use(passport.initialize());
+        if (process.env.SERVICE === 'mock') {
+            // TODO ... is there a real di way to do this??
+            console.log('using the mock passport middlware');
+            var mock = require('./mock-passport-middleware');
+            app.use(mock.initialize(mock.mockUser));
+        } else {
+            app.use(passport.initialize());
+        }
         app.use(passport.session());
 
-
         app.get('/auth/authenticated', function (req, res) {
             var authenticated = req.isAuthenicated();
             if (authenticated) {