stream enhancements #268
Draft
stream enhancements #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VJag
reviewed
Sep 8, 2021
| var fileName = valueObject.split(':')[1]; | ||
| var fileLength = int.parse(valueObject.split(':')[2]); | ||
| fileName = utf8.decode(base64.decode(fileName)); | ||
| final streamNotification = StreamNotificationParser('atmosphere') |
There was a problem hiding this comment.
Why is the atmosphere is typed here?
VJag
reviewed
Sep 8, 2021
| .parseStreamNotification(atNotification); | ||
| if (streamNotification == null) { | ||
| return; | ||
| } | ||
| var userResponse = true; //UI user response | ||
| if (userResponse == true) { | ||
| print('user accepted transfer.Sending ack back'); |
VJag
reviewed
Sep 8, 2021
| @@ -49,7 +61,7 @@ Future<void> _notificationCallBack(AtNotification atNotification) async { | |||
| } | |||
| } | |||
|
|
|||
| void _streamReceiveCallBack(var bytesReceived) { | |||
| void _streamProgressCallBack(var bytesReceived) { | |||
| print('Receive callback bytes received: $bytesReceived'); | |||
VJag
reviewed
Sep 8, 2021
| var atStreamRequest = AtStreamRequest('@bob🛠', '/home/murali/Pictures/@/cat.jpeg'); | ||
| atStreamRequest.namespace = 'atmosphere'; | ||
| final streamSender = | ||
| atClientManager.streamService.createStream(StreamType.SEND).sender; |
There was a problem hiding this comment.
I was thinking "atClientManager.streamService.createStream(StreamType.SEND)" to return a StreamSender without calling a ".sender". Will discuss in a call.
VJag
reviewed
Sep 8, 2021
| onDone(atStreamResponse); | ||
| } | ||
| } else if (result != null && result.startsWith('error:')) { | ||
| result = result.replaceAll('error:', ''); |
VJag
reviewed
Sep 8, 2021
| /// onDone[AtStreamResponse] is called upon stream completion. | ||
| /// onError[AtStreamResponse] is called when stream errors out. | ||
| /// If a stream transfer has to be resumed then specify [atStreamRequest.startByte]. Stream transfer will be resumed from startByte. | ||
| Future<void> send(AtStreamRequest atStreamRequest, Function onDone, |
There was a problem hiding this comment.
Can an app send two-stream requests in parallel? i.e calling send for two files.
There was a problem hiding this comment.
Should the stream id is important for the caller to know before onDone or onError is called?
|
@murali-shris Is there code here which will be useful when we revisit stream properly? If so, please mark as draft for now, otherwise please close and delete the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog