Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated atSigns for client e2e test #512

Merged
merged 8 commits into from
May 20, 2022

Conversation

gkc
Copy link
Contributor

@gkc gkc commented May 13, 2022

- What I did
Fixes #511

- How I did it
Updated e2e tests' config.yaml

- How to verify it
e2e tests should successfully run against the dedicated atSigns

- Description for the changelog
Use dedicated atSigns for client e2e test

@gkc gkc requested a review from cpswan May 16, 2022 19:12
firstAtSign: '@cicd1'
secondAtSign: '@cicd2'
# @ce2e1 is running latest at_secondary_server trunk
# @ce2e3 is running the latest canary release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update this comment line to match

@gkc gkc merged commit e490c1c into trunk May 20, 2022
@gkc gkc deleted the use_dedicated_atsigns_for_client_e2e_test branch May 20, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new dedicated at-signs which have been set up for at_client_sdk e2e tests
3 participants