Use dedicated atSigns for client e2e test #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpswan
reviewed
May 17, 2022
cpswan
requested changes
May 17, 2022
at_end2end_test/config/config.yaml
Outdated
| firstAtSign: '@cicd1' | ||
| secondAtSign: '@cicd2' | ||
| # @ce2e1 is running latest at_secondary_server trunk | ||
| # @ce2e3 is running the latest canary release |
There was a problem hiding this comment.
Just need to update this comment line to match
cpswan
approved these changes
May 18, 2022
…s_for_client_e2e_test
Update ce2 images
…s_for_client_e2e_test
This was referenced May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes #511
- How I did it
Updated e2e tests' config.yaml
- How to verify it
e2e tests should successfully run against the dedicated atSigns
- Description for the changelog
Use dedicated atSigns for client e2e test